drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] kkhatua commented on a change in pull request #1482: DRILL-6762: Dynamic UDFs registered on 1 Drillbit not visible on others
Date Thu, 27 Sep 2018 20:25:22 GMT
kkhatua commented on a change in pull request #1482: DRILL-6762: Dynamic UDFs registered on
1 Drillbit not visible on others
URL: https://github.com/apache/drill/pull/1482#discussion_r221065150
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/registry/RemoteFunctionRegistry.java
 ##########
 @@ -84,6 +84,7 @@
   private static final String registry_path = "registry";
   private static final org.slf4j.Logger logger = org.slf4j.LoggerFactory.getLogger(RemoteFunctionRegistry.class);
   private static final ObjectMapper mapper = new ObjectMapper().enable(INDENT_OUTPUT);
+  public static final int UNREACHABLE = Integer.MIN_VALUE;
 
 Review comment:
   Good catch. I was doing this as part of a patch for another JIRA that is blocked by this,
so I didn't realize the `-1` is actually `-1L`. However, there might be some more work needed
because of the side-effect (like this one) introduced by DRILL-6053. We should have a fix
very soon.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message