drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] arina-ielchiieva commented on a change in pull request #1482: DRILL-6762: Dynamic UDFs registered on 1 Drillbit not visible on others
Date Fri, 28 Sep 2018 09:25:26 GMT
arina-ielchiieva commented on a change in pull request #1482: DRILL-6762: Dynamic UDFs registered
on 1 Drillbit not visible on others
URL: https://github.com/apache/drill/pull/1482#discussion_r221192929
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/registry/RemoteFunctionRegistry.java
 ##########
 @@ -84,6 +84,7 @@
   private static final String registry_path = "registry";
   private static final org.slf4j.Logger logger = org.slf4j.LoggerFactory.getLogger(RemoteFunctionRegistry.class);
   private static final ObjectMapper mapper = new ObjectMapper().enable(INDENT_OUTPUT);
+  public static final int UNREACHABLE = Integer.MIN_VALUE;
 
 Review comment:
   I would suggest we have all versions in int since ZK versioning is always in int.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message