drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] vdiravka commented on a change in pull request #1561: DRILL-6751: Upgrade Apache parent POM to version 21
Date Thu, 06 Dec 2018 01:21:17 GMT
vdiravka commented on a change in pull request #1561: DRILL-6751: Upgrade Apache parent POM
to version 21
URL: https://github.com/apache/drill/pull/1561#discussion_r239277531
 
 

 ##########
 File path: distribution/pom.xml
 ##########
 @@ -156,26 +156,40 @@
 
   <build>
     <plugins>
-    <plugin>
+      <plugin>
         <artifactId>maven-assembly-plugin</artifactId>
         <executions>
-            <execution>
-                <id>distro-assembly</id>
-                <phase>package</phase>
-                <goals>
-                    <goal>single</goal>
-                </goals>
-                <configuration>
-                    <descriptors>
-                        <descriptor>src/assemble/bin.xml</descriptor>
-                    </descriptors>
-                    <appendAssemblyId>false</appendAssemblyId>
-                    <finalName>apache-drill-${project.version}</finalName>
-                    <tarLongFileMode>gnu</tarLongFileMode>
-                </configuration>
-            </execution>
+          <execution>
+            <id>distro-assembly</id>
+            <phase>package</phase>
+            <goals>
+              <goal>single</goal>
+            </goals>
+            <configuration>
+              <descriptors>
+                <descriptor>src/assemble/bin-assembly.xml</descriptor>
+              </descriptors>
+              <appendAssemblyId>false</appendAssemblyId>
+              <finalName>apache-drill-${project.version}</finalName>
+            </configuration>
+          </execution>
+          <execution>
+            <id>distro-assembly-not-attached</id>
+            <phase>package</phase>
+            <goals>
+              <goal>single</goal>
+            </goals>
+            <configuration>
+              <attach>false</attach>
 
 Review comment:
   It attaches a result of assembly as artifacts to the project. `attach` for directory can't
be performed and the following WARNING is obtained on current master branch:
   > [WARNING] Assembly file: <DRILL_HOME>/distribution/target/apache-drill-1.15.0-SNAPSHOT
is not a regular file (it may be a directory). It cannot be attached to the project build
for installation or deployment.
   
   See more in this comment and last comment in that ticket:
   https://issues.apache.org/jira/browse/MASSEMBLY-628?focusedCommentId=14425374&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14425374

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message