drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] vdiravka commented on issue #1561: DRILL-6751: Upgrade Apache parent POM to version 21
Date Thu, 06 Dec 2018 16:13:39 GMT
vdiravka commented on issue #1561: DRILL-6751: Upgrade Apache parent POM to version 21
URL: https://github.com/apache/drill/pull/1561#issuecomment-444928201
 
 
   @sohami Thank you for review.
   
   Looks like there is no more need in converting `RuntimeException` to `SQLException`, it
was resolved in Avatica-1.9.0 for a long time ago, see [CALCITE-1408](https://issues.apache.org/jira/browse/CALCITE-1408)
   For now it is [`SQLDataException`](https://github.com/apache/calcite-avatica/blob/4b7eee5bf430b916c7c07897b6f60d2b6b6dabb7/core/src/main/java/org/apache/calcite/avatica/util/AbstractCursor.java#L367)
(inheritor of `java.sql.SQLException`).
   Therefore no need to have WrappedAccessor in Drill.
   
   I have updated it and squashed "Changes after the review" with the last commit.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message