drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] arina-ielchiieva commented on a change in pull request #1666: DRILL-7058: Refresh command to support subset of columns
Date Fri, 01 Mar 2019 14:16:01 GMT
arina-ielchiieva commented on a change in pull request #1666: DRILL-7058: Refresh command to
support subset of columns
URL: https://github.com/apache/drill/pull/1666#discussion_r261614220
 
 

 ##########
 File path: exec/java-exec/src/main/codegen/includes/parserImpls.ftl
 ##########
 @@ -550,9 +558,9 @@ Pair<SqlNodeList, SqlNodeList> ParenthesizedCompoundIdentifierList()
:
     SqlIdentifier id;
 }
 {
-    id = SimpleIdentifier() {list.add(id);}
+    id = CompoundIdentifier() {list.add(id);}
 
 Review comment:
   1. Why this change is needed? 
   2. Please updated java-doc to reflect new method behavior: `Parses a comma-separated list
of simple identifiers`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message