drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] cgivre commented on issue #1665: DRILL-7054: timestamp in milliseconds
Date Fri, 01 Mar 2019 14:27:10 GMT
cgivre commented on issue #1665: DRILL-7054: timestamp in milliseconds
URL: https://github.com/apache/drill/pull/1665#issuecomment-468681971
 
 
   HI @jculio 
   Take a look at: https://github.com/apache/drill/blob/master/exec/java-exec/src/test/java/org/apache/drill/exec/store/pcap/TestPcapDecoder.java#L57.

   
   Specifically here:  
   https://github.com/apache/drill/blob/fee4b1cdc1a1bf4ac3dfdbbf435a5696540ce59a/exec/java-exec/src/test/java/org/apache/drill/exec/store/pcap/TestPcapDecoder.java#L57
   
   You can just add one line to call your new function and then verify the result.  Once you've
done that, run the test locally to make sure that it works:
   `mvn =Dtest=TestPcapDecoder#testBasics test` and assuming it does, push it to your remote
repo.  
   
   As @vdiravka said, you'll need to squash your commits into one.  Here's how: After verifying
that everything is working, count how many commits you have made.
   Then:
   
   ```
   git reset --soft HEAD~3
   git commit -m "DRILL-7054: timestamp in milliseconds"
   git push origin +master
   ```
   
   The first line there uncommits the last `n` commits you made.  The second line then recommits
everything into one commit.  Note that Drill requires commits to have a message identifying
the PR.  The final line pushes everything back to github and overwrites the previous commits
on github with one commit.  
   
   Thank you very much for this contribution!!
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message