drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] vvysotskyi commented on a change in pull request #1657: DRILL-5603: Replace String file paths to Hadoop Path
Date Fri, 01 Mar 2019 17:06:21 GMT
vvysotskyi commented on a change in pull request #1657: DRILL-5603: Replace String file paths
to Hadoop Path
URL: https://github.com/apache/drill/pull/1657#discussion_r261644721
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/PruneScanRule.java
 ##########
 @@ -420,9 +423,10 @@ protected void doOnMatch(RelOptRuleCall call, Filter filterRel, Project
projectR
             }
           }
           for (int j=0; j <= index; j++) {
-            path += "/" + spInfo[j];
+            path.append("/")
+                .append(spInfo[j]);
           }
-          cacheFileRoot = descriptor.getBaseTableLocation() + path;
+          cacheFileRoot = Path.mergePaths(descriptor.getBaseTableLocation(), createPathSafe(path.toString()));
 
 Review comment:
   Could you please specify a class name with the call of this method: `createPathSafe` ->
`DrillFileSystemUtil.createPathSafe`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message