drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] vvysotskyi commented on a change in pull request #1656: DRILL-7056: Drill fails with NPE when starting in distributed mode & …
Date Fri, 01 Mar 2019 18:28:46 GMT
vvysotskyi commented on a change in pull request #1656: DRILL-7056: Drill fails with NPE when
starting in distributed mode & …
URL: https://github.com/apache/drill/pull/1656#discussion_r261694979
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/WebServer.java
 ##########
 @@ -467,43 +452,64 @@ public void close() throws Exception {
     if (embeddedJetty != null) {
       embeddedJetty.stop();
     }
-    //Deleting temp directory
-    FileUtils.deleteDirectory(getTmpJavaScriptDir());
+    // Deleting temp directory, if it exists
+    if (tmpJavaScriptDir != null) {
+      FileUtils.deleteDirectory(tmpJavaScriptDir);
 
 Review comment:
   Please replace it with `FileUtils.deleteQuietly` and remove the null check, since it will
be produced inside this method.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message