drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] Agirish commented on a change in pull request #1663: DRILL-7060: Support JsonParser Feature 'ALLOW_BACKSLASH_ESCAPING_ANY_CHARACTER'
Date Sun, 03 Mar 2019 07:22:39 GMT
Agirish commented on a change in pull request #1663: DRILL-7060: Support JsonParser Feature
'ALLOW_BACKSLASH_ESCAPING_ANY_CHARACTER'
URL: https://github.com/apache/drill/pull/1663#discussion_r261854416
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java
 ##########
 @@ -108,6 +109,7 @@ public Builder(DrillBuf managedBuf) {
       this.skipOuterList = false;
       this.allTextMode = false;
       this.enableNanInf = true;
+      this.enableEscapeAnyChar = false;
 
 Review comment:
   Lines above this are setting this to false explicitly, so to keep it consistent I set it
to false. But sure, I can change it. Do I also change others to remove the explicit false
assignment?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message