drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [drill] arina-ielchiieva commented on a change in pull request #1690: DRILL-7086: Output schema for row set mechanism
Date Tue, 12 Mar 2019 13:53:15 GMT
arina-ielchiieva commented on a change in pull request #1690: DRILL-7086: Output schema for
row set mechanism
URL: https://github.com/apache/drill/pull/1690#discussion_r264646987
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/impl/ColumnBuilder.java
 ##########
 @@ -121,12 +179,38 @@ public static ColumnState buildColumn(ContainerState parent, ColumnMetadata
colu
    * and manages the column.
    *
    * @param columnSchema schema of the new primitive column
+   * @param projType implied projection type for the column
    * @return column state for the new column
    */
 
-  private static ColumnState buildPrimitive(ContainerState parent, ColumnMetadata columnSchema)
{
+  private ColumnState buildPrimitive(ContainerState parent, ColumnTransformer outputCol)
{
+    ProjectionType projType = outputCol.projectionType();
+    ColumnMetadata columnSchema = outputCol.outputSchema();
+
+    // Enforce correspondence between implied type from the projection list
+    // and the actual type of the column.
+
+    switch (projType) {
+    case ARRAY:
 
 Review comment:
   Same here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message