drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [drill] arina-ielchiieva commented on a change in pull request #1690: DRILL-7086: Output schema for row set mechanism
Date Tue, 12 Mar 2019 13:53:15 GMT
arina-ielchiieva commented on a change in pull request #1690: DRILL-7086: Output schema for
row set mechanism
URL: https://github.com/apache/drill/pull/1690#discussion_r264648106
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/impl/ColumnBuilder.java
 ##########
 @@ -292,12 +412,22 @@ private static ColumnState buildMapArray(ContainerState parent, ColumnMetadata
c
    * @param columnSchema column schema
    * @return column
    */
-  private static ColumnState buildUnion(ContainerState parent, ColumnMetadata columnSchema)
{
+  private ColumnState buildUnion(ContainerState parent, ColumnTransformer outputCol) {
+    ProjectionType projType = outputCol.projectionType();
+    ColumnMetadata columnSchema = outputCol.outputSchema();
     assert columnSchema.isVariant() && ! columnSchema.isArray();
 
-    if (! columnSchema.isProjected()) {
+    switch (projType) {
+    case ARRAY:
 
 Review comment:
   Same here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message