drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [drill] arina-ielchiieva commented on a change in pull request #1690: DRILL-7086: Output schema for row set mechanism
Date Tue, 12 Mar 2019 13:53:15 GMT
arina-ielchiieva commented on a change in pull request #1690: DRILL-7086: Output schema for
row set mechanism
URL: https://github.com/apache/drill/pull/1690#discussion_r264688160
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/impl/OptionBuilder.java
 ##########
 @@ -129,10 +133,60 @@ public OptionBuilder setSchema(TupleMetadata schema) {
     return this;
   }
 
+  /**
+   * Provide an optional column conversion factory. Can create a "shim"
 
 Review comment:
   From the description is not quite clear to me why we need to both options: column conversions
and schema transform. Could not we have only one that would function as both? Can you please
explain a little bit more?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message