drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [drill] vdiravka commented on a change in pull request #1686: DRILL-6524: Prevent incorrect scalar replacement for the case of assigning references inside if block
Date Tue, 12 Mar 2019 16:43:59 GMT
vdiravka commented on a change in pull request #1686: DRILL-6524: Prevent incorrect scalar
replacement for the case of assigning references inside if block
URL: https://github.com/apache/drill/pull/1686#discussion_r264375432
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/compile/bytecode/MethodAnalyzer.java
 ##########
 @@ -36,70 +46,147 @@
  * as factories that will provide our own derivative of Frame<> which we use to detect
  */
 public class MethodAnalyzer<V extends Value> extends Analyzer <V> {
+
+  // list of method instructions which is analyzed
+  private InsnList insnList;
+
+  /**
+   * Constructor.
 
 Review comment:
   parent class has a good Javadoc. This one can be removed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message