drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [drill] ihuzenko commented on a change in pull request #1829: DRILL-7096: Develop vector for canonical Map<K, V>
Date Mon, 02 Sep 2019 11:58:26 GMT
ihuzenko commented on a change in pull request #1829: DRILL-7096: Develop vector for canonical
Map<K,V>
URL: https://github.com/apache/drill/pull/1829#discussion_r319923286
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/record/TypedFieldId.java
 ##########
 @@ -149,16 +156,44 @@ public static Builder newBuilder() {
     return new Builder();
   }
 
-  public static class Builder{
+  public static class Builder {
     final IntArrayList ids = new IntArrayList();
     MajorType finalType;
     MajorType intermediateType;
     MajorType secondaryFinal;
     PathSegment remainder;
-    boolean hyperReader = false;
-    boolean withIndex = false;
-    boolean isListVector = false;
-    Map<Integer, MajorType> types = new HashMap<>();
+    boolean hyperReader;
+    boolean withIndex;
+    boolean isListVector;
+    BitSet dictBitSet = new BitSet();
+
+    public static TypedFieldId build(MajorType type, int... fieldIds) {
 
 Review comment:
   is it possible to get rid of overloaded ```build(...)``` methods completely ?  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message