drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [drill] cgivre commented on issue #1840: DRILL-7343: Add User-Agent UDFs to Drill
Date Wed, 04 Sep 2019 14:48:54 GMT
cgivre commented on issue #1840: DRILL-7343: Add User-Agent UDFs to Drill
URL: https://github.com/apache/drill/pull/1840#issuecomment-527935677
 
 
   @KazydubB 
   What happens in the `parse_query` function is that there is a duplicate function of the
same name which allows null input which returns an empty list.  I had tried this before, but
apparently didn't use the correct parameters so it didn't work for me, BUT, now it does so
yay!
   
   In any event, this seems like horrible design.  I'm going to open a JIRA to create a new
function handler which returns an empty list on null.  That seems like a better approach than
having to write 2 UDFS for every UDF with a complex writer output. 
   
   I also added a series of unit tests to test this functionality. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message