drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [drill] ihuzenko commented on a change in pull request #1854: DRILL-7373: Fix problems involving reading from DICT type
Date Fri, 13 Sep 2019 16:18:47 GMT
ihuzenko commented on a change in pull request #1854: DRILL-7373: Fix problems involving reading
from DICT type
URL: https://github.com/apache/drill/pull/1854#discussion_r324252640
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillOptiq.java
 ##########
 @@ -251,6 +254,9 @@ public LogicalExpression visitCall(RexCall call) {
         if (call.getOperator() == SqlStdOperatorTable.ITEM) {
 
 Review comment:
   I believe that logic inside the ```if (call.getOperator() == SqlStdOperatorTable.ITEM)
{``` may be extracted to separate method, although there is some ```// fall through``` at
the end of if it's actually visible that at the end of ```visitCall(RexCall call)``` it'll
be finished by assertion error. Also the newly added ```switch-case``` expressions may be
extracted to separate methods too. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message