drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [drill] ihuzenko commented on a change in pull request #1854: DRILL-7373: Fix problems involving reading from DICT type
Date Fri, 13 Sep 2019 16:18:47 GMT
ihuzenko commented on a change in pull request #1854: DRILL-7373: Fix problems involving reading
from DICT type
URL: https://github.com/apache/drill/pull/1854#discussion_r324266866
 
 

 ##########
 File path: logical/src/main/java/org/apache/drill/common/expression/PathSegment.java
 ##########
 @@ -17,13 +17,29 @@
  */
 package org.apache.drill.common.expression;
 
+import org.apache.drill.common.types.TypeProtos;
+
 public abstract class PathSegment {
 
+  /**
+   * Holds original value associated with the path segment.
+   * Used when reading data from DICT.
+   */
+  protected final Object originalValue;
+
+  /**
+   * Indicates the type of original value.
+   * @see #originalValue
+   */
+  protected final TypeProtos.MajorType valueType;
 
 Review comment:
   ```suggestion
     protected final TypeProtos.MajorType originalValueType;
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message