drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [drill] paul-rogers commented on a change in pull request #2006: DRILL-7615: UNION ALL query returns the wrong result for the decimal value
Date Tue, 03 Mar 2020 03:22:17 GMT
paul-rogers commented on a change in pull request #2006: DRILL-7615: UNION ALL query returns
the wrong result for the decimal value
URL: https://github.com/apache/drill/pull/2006#discussion_r386776273
 
 

 ##########
 File path: common/src/main/java/org/apache/drill/common/types/Types.java
 ##########
 @@ -131,6 +132,17 @@ public static boolean isIntervalType(MinorType type) {
     }
   }
 
+  /**
+   * Returns true if all specified types are decimal data types.
+   *
+   * @param types types to check
+   * @return true if all specified types are decimal data type.
+   */
+  public static boolean areDecimalTypes(MajorType... types) {
 
 Review comment:
   General enough to define as a method? Seems we'd end up having similar methods for many
predicates.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message