drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [drill] paul-rogers commented on a change in pull request #2000: DRILL-7607: Support dynamic credit based flow control
Date Tue, 03 Mar 2020 03:35:50 GMT
paul-rogers commented on a change in pull request #2000: DRILL-7607: Support dynamic credit
based flow control
URL: https://github.com/apache/drill/pull/2000#discussion_r386781840
 
 

 ##########
 File path: exec/java-exec/src/main/resources/drill-module.conf
 ##########
 @@ -248,6 +248,9 @@ drill.exec: {
     spooling: {
       delete: true,
       size: 100000000
+    },
+    unlimited: {
+      size: 500000000
 
 Review comment:
   The name seems confusing. "Unlmited" means (except in American cell phone plans) that there
is no limit. Yet, we see a limit with the `size`. Is this the `receive_buffer_size`? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message