drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [drill] arina-ielchiieva commented on a change in pull request #2000: DRILL-7607: Support dynamic credit based flow control
Date Tue, 03 Mar 2020 09:13:35 GMT
arina-ielchiieva commented on a change in pull request #2000: DRILL-7607: Support dynamic credit
based flow control
URL: https://github.com/apache/drill/pull/2000#discussion_r386884155
 
 

 ##########
 File path: protocol/src/main/protobuf/BitData.proto
 ##########
 @@ -36,6 +36,8 @@ enum RpcType {
   SASL_MESSAGE = 4;
 
   REQ_RUNTIME_FILTER = 5; // send runtime filter data from HashJoin to Foreman, from Foreman
to Scan nodes.
+
+  DATA_ACK_WITH_CREDIT = 6; // a ack for data tunnel ,with a runtime suggest credit as a
response
 
 Review comment:
   ```suggestion
     DATA_ACK_WITH_CREDIT = 6; // a ack for data tunnel, with a runtime suggests credit as
a response
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message