drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [drill] vvysotskyi commented on a change in pull request #2026: DRILL-7330: Implement metadata usage for all format plugins
Date Sat, 14 Mar 2020 09:34:26 GMT
vvysotskyi commented on a change in pull request #2026: DRILL-7330: Implement metadata usage
for all format plugins
URL: https://github.com/apache/drill/pull/2026#discussion_r392571650
 
 

 ##########
 File path: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/scan/TestFileScanFramework.java
 ##########
 @@ -25,6 +25,8 @@
 import java.util.Iterator;
 import java.util.List;
 
+import mockit.Mock;
+import mockit.MockUp;
 
 Review comment:
   These tests use non-existent data files for populating the implicit column values, but
with new changes, the file system is used to obtain other implicit column values such as last
modified time. So mock was used to avoid rewriting tests to use real files. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message