drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [drill] paul-rogers commented on a change in pull request #2026: DRILL-7330: Implement metadata usage for all format plugins
Date Sat, 14 Mar 2020 19:37:15 GMT
paul-rogers commented on a change in pull request #2026: DRILL-7330: Implement metadata usage
for all format plugins
URL: https://github.com/apache/drill/pull/2026#discussion_r392608554
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/scan/file/ImplicitColumnManager.java
 ##########
 @@ -81,40 +83,36 @@
     protected boolean useLegacyWildcardExpansion = true;
 
     /**
-      * Specify the selection root for a directory scan, if any.
-      * Used to populate partition columns. Also, specify the maximum
-      * partition depth.
-      *
-      * @param rootPath Hadoop file path for the directory
-      * @param partitionDepth maximum partition depth across all files
-      * within this logical scan operator (files in this scan may be
-      * shallower)
-      */
-
-     public void setSelectionRoot(Path rootPath) {
-       this.rootDir = rootPath;
-     }
-
-     public void setPartitionDepth(int partitionDepth) {
-       this.partitionCount = partitionDepth;
-     }
-
-     public void setFiles(List<Path> files) {
+     * Specify the selection root for a directory scan, if any.
+     * Used to populate partition columns. Also, specify the maximum
+     * partition depth.
+     *
+     * @param rootPath Hadoop file path for the directory
+     */
+    public void setSelectionRoot(Path rootPath) {
+      this.rootDir = rootPath;
+    }
+
+    public void setPartitionDepth(int partitionDepth) {
+      this.partitionCount = partitionDepth;
+    }
+
+    public void setFiles(List<Path> files) {
       this.files = files;
     }
 
-     /**
-      * Indicates whether to expand partition columns when the query contains a wildcard.
-      * Supports queries such as the following:<code><pre>
-      * select * from dfs.`partitioned-dir`</pre></code>
-      * In which the output columns will be (columns, dir0) if the partitioned directory
-      * has one level of nesting.
-      *
-      * See {@link TestImplicitFileColumns#testImplicitColumns}
-      */
-     public void useLegacyWildcardExpansion(boolean flag) {
-       useLegacyWildcardExpansion = flag;
-     }
+    /**
+     * Indicates whether to expand partition columns when the query contains a wildcard.
+     * Supports queries such as the following:<code><pre>
+     * select * from dfs.`partitioned-dir`</pre></code>
+     * In which the output columns will be (columns, dir0) if the partitioned directory
+     * has one level of nesting.
+     * <p>
+     * See {@code TestImplicitFileColumns#testImplicitColumns}
 
 Review comment:
   Maybe `@see`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message