drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [drill] paul-rogers commented on a change in pull request #2026: DRILL-7330: Implement metadata usage for all format plugins
Date Sat, 14 Mar 2020 19:37:15 GMT
paul-rogers commented on a change in pull request #2026: DRILL-7330: Implement metadata usage
for all format plugins
URL: https://github.com/apache/drill/pull/2026#discussion_r392611244
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/easy/EasyGroupScan.java
 ##########
 @@ -230,6 +230,16 @@ public void modifyFileSelection(FileSelection selection) {
     this.selection = selection;
   }
 
+  @Override
+  protected boolean supportsFileImplicitColumns() {
+    return true;
+  }
 
 Review comment:
   This same info is passed to the EVF-based mechanism. Should this instead be specified on
the format plugin and used both here and in the EVF builder so we get consistent results?
Otherwise, how will folks like @cgivre know to specify the same thing twice?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message