drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [drill] paul-rogers commented on a change in pull request #2026: DRILL-7330: Implement metadata usage for all format plugins
Date Sat, 14 Mar 2020 19:37:16 GMT
paul-rogers commented on a change in pull request #2026: DRILL-7330: Implement metadata usage
for all format plugins
URL: https://github.com/apache/drill/pull/2026#discussion_r392613377
 
 

 ##########
 File path: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/scan/TestFileScanFramework.java
 ##########
 @@ -25,6 +25,8 @@
 import java.util.Iterator;
 import java.util.List;
 
+import mockit.Mock;
+import mockit.MockUp;
 
 Review comment:
   What we want is to pass into the implicit column provider an interface that will answer
file-specific questions. That is the thing that holds the file system. For testing, implement
the interface to pretend to read files. For DFS, implement a real interface.
   
   This will also allow someone to implement their own version for systems not based on DFS.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message