drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [drill] paul-rogers commented on a change in pull request #2026: DRILL-7330: Implement metadata usage for all format plugins
Date Sat, 14 Mar 2020 19:37:16 GMT
paul-rogers commented on a change in pull request #2026: DRILL-7330: Implement metadata usage
for all format plugins
URL: https://github.com/apache/drill/pull/2026#discussion_r392613050
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/FilePushDownFilter.java
 ##########
 @@ -244,4 +247,15 @@ protected void doOnMatch(RelOptRuleCall call, FilterPrel filter, ProjectPrel
pro
     final RelNode newFilter = filter.copy(filter.getTraitSet(), Collections.singletonList(newNode));
     call.transformTo(newFilter);
   }
+
+  /**
+   * Checks whether specified group scan supports filter push down.
+   *
+   * @param groupScan group scan to check
+   * @return {@code true} if specified group scan supports filter push down, {@code false}
otherwise
+   */
+  private static boolean supportsFilterPushDown(GroupScan groupScan) {
+    return groupScan instanceof AbstractGroupScanWithMetadata
 
 Review comment:
   This kind of logic is fragile. Can we just add a method on the group scan that will answer
this question, then let each group scan figure out the answer or itself?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message