drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [drill] rymarm commented on a change in pull request #2185: DRILL-7790 : Build Drill with Netty version 4.1.59.Final
Date Wed, 10 Mar 2021 09:16:42 GMT

rymarm commented on a change in pull request #2185:
URL: https://github.com/apache/drill/pull/2185#discussion_r591253117



##########
File path: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserServer.java
##########
@@ -284,14 +282,9 @@ public void sendData(final RpcOutcomeListener<Ack> listener, final
QueryDataPack
     }
 
     @Override
-    public ChannelFuture getChannelClosureFuture() {
+    public Future getClosureFuture() {

Review comment:
       Fixed.

##########
File path: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/BaseWebUserConnection.java
##########
@@ -40,7 +39,7 @@ public UserSession getSession() {
   }
 
   @Override
-  public ChannelFuture getChannelClosureFuture() {
+  public Future getClosureFuture() {

Review comment:
       Fixed.

##########
File path: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/DrillRestServer.java
##########
@@ -221,11 +221,11 @@ public WebUserConnection provide() {
                 config.getLong(ExecConstants.HTTP_SESSION_MEMORY_RESERVATION),
                 config.getLong(ExecConstants.HTTP_SESSION_MEMORY_MAXIMUM));
 
-        // Create a dummy close future which is needed by Foreman only. Foreman uses this
future to add a close
+        // Create a future which is needed by Foreman only. Foreman uses this future to add
a close
         // listener to known about channel close event from underlying layer. We use this
future to notify Foreman
         // listeners when the Web session (not connection) between Web Client and WebServer
is closed. This will help
         // Foreman to cancel all the running queries for this Web Client.
-        final ChannelPromise closeFuture = new DefaultChannelPromise(null, executor);
+        final Promise closeFuture = new DefaultPromise(executor);

Review comment:
       Fixed.

##########
File path: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/DrillRestServer.java
##########
@@ -283,12 +283,12 @@ public WebUserConnection provide() {
         logger.trace("Failed to get the remote address of the http session request", ex);
       }
 
-      // Create a dummy close future which is needed by Foreman only. Foreman uses this future
to add a close
+      // Create a close future which is needed by Foreman only. Foreman uses this future
to add a close
       // listener to known about channel close event from underlying layer.
       //
       // The invocation of this close future is no-op as it will be triggered after query
completion in unsecure case.
       // But we need this close future as it's expected by Foreman.
-      final ChannelPromise closeFuture = new DefaultChannelPromise(null, executor);
+      final Promise closeFuture = new DefaultPromise(executor);

Review comment:
       Fixed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message