drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [drill] cgivre commented on a change in pull request #2216: DRILL-7918: Dependency Updates for CVE
Date Tue, 04 May 2021 22:55:04 GMT

cgivre commented on a change in pull request #2216:
URL: https://github.com/apache/drill/pull/2216#discussion_r626160701



##########
File path: contrib/storage-kudu/pom.xml
##########
@@ -57,7 +57,7 @@
     <dependency>
       <groupId>org.apache.kudu</groupId>
       <artifactId>kudu-client</artifactId>
-      <version>1.3.0</version>
+      <version>1.14.0</version>

Review comment:
       > Could you please confirm that with the update Drill is able to connect to Kudu?
Also, there are no enabled unit tests for Kudu, existing ones are disabled and require running
Kudu server.
   > Could you please update tests to start Kudu using testcontainers, so we will be sure
that it is still working correctly?
   
   Sure!  I've never really used Kudu and don't know much about how it works, but I think
I can figure out `testcontainers` and there is a docker container for Kudu.  I'll follow the
examples in the Splunk plugin.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message