drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [drill] cgivre commented on a change in pull request #2241: DRILL-7938: Convert JDBC Storage Plugin to EVF
Date Wed, 02 Jun 2021 13:56:10 GMT

cgivre commented on a change in pull request #2241:
URL: https://github.com/apache/drill/pull/2241#discussion_r643988575



##########
File path: contrib/storage-jdbc/src/test/java/org/apache/drill/exec/store/jdbc/TestJdbcPluginWithH2IT.java
##########
@@ -53,6 +54,10 @@
   @BeforeClass
   public static void init() throws Exception {
     startCluster(ClusterFixture.builder(dirTestWatcher));
+    // Force timezone to UTC for these tests.

Review comment:
       Good call.  I wonder if it might actually make sense to include that in the actual
test architecture as there have been a lot of issues with unit tests and timezones.  What
do you think?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message