drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [drill] vvysotskyi commented on a change in pull request #2244: DRILL-7941 Update JUnit from 4.13.2 to 5.7.2
Date Thu, 03 Jun 2021 16:08:24 GMT

vvysotskyi commented on a change in pull request #2244:
URL: https://github.com/apache/drill/pull/2244#discussion_r644929089



##########
File path: common/pom.xml
##########
@@ -37,11 +37,21 @@
       <artifactId>drill-protocol</artifactId>
       <version>${project.version}</version>
     </dependency>
+    <dependency>
+      <groupId>org.junit.jupiter</groupId>
+      <artifactId>junit-jupiter-engine</artifactId>
+      <version>${junit.version}</version>
+    </dependency>
+    <dependency>
+      <groupId>org.junit.vintage</groupId>
+      <artifactId>junit-vintage-engine</artifactId>
+      <version>${junit.version}</version>
+    </dependency>
     <dependency>
       <!-- add as provided scope so that we can compile TestTools.  Should only be ever
used in a test scenario where someone else is bringing JUnit in. -->
       <groupId>junit</groupId>
       <artifactId>junit</artifactId>
-      <version>${junit.version}</version>
+      <scope>provided</scope>

Review comment:
       Please remove junit / jupiter dependencies from here and move `RepeatTestRule` to the
tests folder.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message