drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [drill] martin-g commented on pull request #2246: DRILL-7943 Update Hamcrest to 2.2
Date Fri, 04 Jun 2021 08:32:01 GMT

martin-g commented on pull request #2246:
URL: https://github.com/apache/drill/pull/2246#issuecomment-853636660


   >  Just curious but is there a reason why we don't just use `junit` and remove this
dependency altogether?
   
   JUnit provides just `Assert.assertThat(String reason, T actual, Matcher<? super T>
matcher)`, Hamcrest provides the actual matcher implementations. 
   
   JUnit's `assertThat()` is linked to Hamcrest 1.3 Matcher. This is the reason to replace
it with `org.hamcrest.MatcherAssert.assertThat()` in this PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message