drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [drill] cgivre commented on a change in pull request #2283: DRILL-7979: Self-Closing XML Tags Cause Schema Change Exceptions
Date Mon, 02 Aug 2021 22:34:11 GMT

cgivre commented on a change in pull request #2283:
URL: https://github.com/apache/drill/pull/2283#discussion_r681310590



##########
File path: contrib/format-xml/src/main/java/org/apache/drill/exec/store/xml/XMLReader.java
##########
@@ -72,9 +72,10 @@
   private InputStream fsStream;
   private XMLEventReader reader;
   private ImplicitColumns metadata;
+  private boolean isSelfClosingEvent;

Review comment:
       I thought about this, however the issue is where the self-closing tag occurs.  Adding
an additional state might mess with the other functionality. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message