drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [drill] dzamo edited a comment on pull request #2284: DRILL-7926: Age Function Fix
Date Wed, 04 Aug 2021 03:15:09 GMT

dzamo edited a comment on pull request #2284:
URL: https://github.com/apache/drill/pull/2284#issuecomment-892035292


   @paul-rogers. I think we lost Oleg on #2268.  I've closed that and opened this PR based
on where he got to, plus some fixes relating to his assumptions of UTC and Unix times.  The
fixes take care of the problem revealed by `select age(current_date)`, but other tests reveal
another problem with java.time code used, in that intervals that span midnight are reported
to be a whole day long, even when they're a few minutes.
   
   I'll request a review once the problem above is fixed and the tests are expanded.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message