drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [drill] vdiravka commented on a change in pull request #2287: DRILL-7982: Timed out waiting for container port to open
Date Thu, 05 Aug 2021 16:17:14 GMT

vdiravka commented on a change in pull request #2287:
URL: https://github.com/apache/drill/pull/2287#discussion_r683601103



##########
File path: contrib/storage-cassandra/src/test/java/org/apache/drill/exec/store/cassandra/TestCassandraSuit.java
##########
@@ -65,7 +66,12 @@ public static void tearDownCluster() {
 
   private static void startCassandra() {
     cassandra = new CassandraContainer<>("cassandra")
-        .withInitScript("queries.cql");
+                      .withInitScript("queries.cql")
+                      .withStartupTimeout(Duration.ofMinutes(3))
+                        .withEnv("CASSANDRA_SNITCH", "GossipingPropertyFileSnitch") // Tune
Cassandra options for faster startup
+                          .withEnv("JVM_OPTS", "-Dcassandra.skip_wait_for_gossip_to_settle=0
-Dcassandra.initial_token=0")
+                            .withEnv("HEAP_NEWSIZE", "128M")
+                              .withEnv("MAX_HEAP_SIZE", "1024M");

Review comment:
       > The Cassandra tests seem to keep timing out and breaking the CI. My recollection
of the Cassandra plugin was that Cassandra really does take a long time to start up, possibly
more than 1 minute. This was why we implemented it to preserve the connection as long as possible
rather than creating tons of new connections.
   
   I am aware about timing out test of container for Cassandra plugin. I also fixed that several
days ago in my branch. But I didn't merge it, because this is not only the one issue on CI
and don't fix CI build. For instance the CI build is restarted several times for this PR and
still not green.
   
   --------------------------------------------------------------------------------------------------------------------------------------------
   > To my knowledge, the Splunk ones are working fine in the CI.
   
   My question was about memory options only in the above comment and `luocooong` answered
that he is going to eliminate them.
   
   --------------------------------------------------------------------------------------------------------------------------------------------
   > It makes me wonder, should we add the GossipingPropertyFileSnitch parameter to the
Cassandra plugin?
   
   [GossipingPropertyFileSnitch](https://github.com/PaytmLabs/cassandra/blob/master/src/java/org/apache/cassandra/locator/GossipingPropertyFileSnitch.java)
looks Cassandra specific code only.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message