dubbo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] diecui1202 commented on a change in pull request #2468: Simplify registry data and add a new service data store seperated from registry #2030
Date Fri, 07 Sep 2018 09:35:24 GMT
diecui1202 commented on a change in pull request #2468: Simplify registry data and add a new
service data store seperated from registry #2030
URL: https://github.com/apache/incubator-dubbo/pull/2468#discussion_r215902240
 
 

 ##########
 File path: dubbo-common/src/main/java/org/apache/dubbo/common/URL.java
 ##########
 @@ -250,6 +250,47 @@ public static URL valueOf(String url) {
         return new URL(protocol, username, password, host, port, path, parameters);
     }
 
+    public static URL valueOf(String url, String... reserveParams){
+        URL result = valueOf(url);
+        if (reserveParams == null || reserveParams.length == 0){
+            return result;
+        }
+        Map<String, String> newMap = new HashMap<String,String>(reserveParams.length);
+        Map<String, String> oldMap = result.getParameters();
+        for(String reserveParam : reserveParams){
 
 Review comment:
   code format

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Mime
View raw message