dubbo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] codecov-io edited a comment on issue #2172: Optimize leastActiveSelect and weight test case
Date Thu, 20 Sep 2018 07:50:39 GMT
codecov-io edited a comment on issue #2172: Optimize leastActiveSelect and weight test case
URL: https://github.com/apache/incubator-dubbo/pull/2172#issuecomment-409899161
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2172?src=pr&el=h1) Report
   > Merging [#2172](https://codecov.io/gh/apache/incubator-dubbo/pull/2172?src=pr&el=desc)
into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/b411a777b3d3111dcdea0cd6d88151b3358665b8?src=pr&el=desc)
will **decrease** coverage by `0.04%`.
   > The diff coverage is `83.33%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/2172/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/2172?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##             master   #2172      +/-   ##
   ===========================================
   - Coverage     55.04%     55%   -0.05%     
   + Complexity     5281    5280       -1     
   ===========================================
     Files           573     573              
     Lines         25490   25490              
     Branches       4526    4526              
   ===========================================
   - Hits          14031   14020      -11     
   - Misses         9363    9375      +12     
   + Partials       2096    2095       -1
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/2172?src=pr&el=tree)
| Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...pc/cluster/loadbalance/LeastActiveLoadBalance.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2172/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvbG9hZGJhbGFuY2UvTGVhc3RBY3RpdmVMb2FkQmFsYW5jZS5qYXZh)
| `70.58% <83.33%> (ø)` | `6 <0> (ø)` | :arrow_down: |
   | [...he/dubbo/remoting/transport/netty/NettyClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2172/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eUNsaWVudC5qYXZh)
| `72.88% <0%> (-10.17%)` | `12% <0%> (-1%)` | |
   | [...apache/dubbo/rpc/protocol/dubbo/FutureAdapter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2172/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL0Z1dHVyZUFkYXB0ZXIuamF2YQ==)
| `58.06% <0%> (-6.46%)` | `3% <0%> (ø)` | |
   | [...dubbo/rpc/protocol/dubbo/CallbackServiceCodec.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2172/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL0NhbGxiYWNrU2VydmljZUNvZGVjLmphdmE=)
| `77.2% <0%> (-1.48%)` | `29% <0%> (ø)` | |
   | [...apache/dubbo/rpc/protocol/dubbo/DubboProtocol.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2172/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL0R1YmJvUHJvdG9jb2wuamF2YQ==)
| `58.33% <0%> (-0.84%)` | `30% <0%> (-1%)` | |
   | [.../dubbo/remoting/transport/netty4/NettyChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2172/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5Q2hhbm5lbC5qYXZh)
| `66.25% <0%> (+1.25%)` | `23% <0%> (+1%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2172?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2172?src=pr&el=footer).
Last update [b411a77...a8dcb28](https://codecov.io/gh/apache/incubator-dubbo/pull/2172?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Mime
View raw message