dubbo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] diecui1202 commented on a change in pull request #2529: Optimization unnecessary unboxing 'b.booleanValue()' and Remove invalid throws java.lang.Exception
Date Fri, 21 Sep 2018 01:00:48 GMT
diecui1202 commented on a change in pull request #2529: Optimization unnecessary unboxing 'b.booleanValue()'
and Remove invalid  throws java.lang.Exception
URL: https://github.com/apache/incubator-dubbo/pull/2529#discussion_r219359408
 
 

 ##########
 File path: dubbo-config/dubbo-config-spring/src/main/java/org/apache/dubbo/config/spring/ReferenceBean.java
 ##########
 @@ -79,13 +77,13 @@ public boolean isSingleton() {
 
     @Override
     @SuppressWarnings({"unchecked"})
-    public void afterPropertiesSet() throws Exception {
 
 Review comment:
   IMO, this throws Exception need to keep. Check org.springframework.beans.factory.InitializingBean#afterPropertiesSet

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Mime
View raw message