dubbo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] codecov-io edited a comment on issue #2529: Optimization unnecessary unboxing 'b.booleanValue()' and Remove invalid throws java.lang.Exception
Date Fri, 21 Sep 2018 01:54:26 GMT
codecov-io edited a comment on issue #2529: Optimization unnecessary unboxing 'b.booleanValue()'
and Remove invalid  throws java.lang.Exception
URL: https://github.com/apache/incubator-dubbo/pull/2529#issuecomment-422820451
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2529?src=pr&el=h1) Report
   > Merging [#2529](https://codecov.io/gh/apache/incubator-dubbo/pull/2529?src=pr&el=desc)
into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/cd60e58e1a579749c89c6ac8ddb39f8e8e894ef5?src=pr&el=desc)
will **decrease** coverage by `0.04%`.
   > The diff coverage is `12.5%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/2529/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/2529?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2529      +/-   ##
   ============================================
   - Coverage     55.06%   55.01%   -0.05%     
   + Complexity     5282     5281       -1     
   ============================================
     Files           573      573              
     Lines         25490    25502      +12     
     Branches       4526     4526              
   ============================================
   - Hits          14035    14031       -4     
   - Misses         9360     9376      +16     
     Partials       2095     2095
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/2529?src=pr&el=tree)
| Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [.../org/apache/dubbo/config/spring/ReferenceBean.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2529/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvUmVmZXJlbmNlQmVhbi5qYXZh)
| `45.67% <12.5%> (ø)` | `20 <0> (ø)` | :arrow_down: |
   | [...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2529/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL0NoYW5uZWxXcmFwcGVkSW52b2tlci5qYXZh)
| `41.66% <0%> (-8.34%)` | `3% <0%> (ø)` | |
   | [...apache/dubbo/rpc/protocol/dubbo/FutureAdapter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2529/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL0Z1dHVyZUFkYXB0ZXIuamF2YQ==)
| `58.06% <0%> (-6.46%)` | `3% <0%> (ø)` | |
   | [...org/apache/dubbo/rpc/filter/ActiveLimitFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2529/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9maWx0ZXIvQWN0aXZlTGltaXRGaWx0ZXIuamF2YQ==)
| `83.33% <0%> (-5.56%)` | `6% <0%> (-1%)` | |
   | [.../dubbo/remoting/transport/netty4/NettyChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2529/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5Q2hhbm5lbC5qYXZh)
| `61.17% <0%> (-5.08%)` | `22% <0%> (-1%)` | |
   | [...exchange/support/header/HeaderExchangeChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2529/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L2hlYWRlci9IZWFkZXJFeGNoYW5nZUNoYW5uZWwuamF2YQ==)
| `79.16% <0%> (-4.35%)` | `35% <0%> (ø)` | |
   | [...dubbo/rpc/protocol/dubbo/CallbackServiceCodec.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2529/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL0NhbGxiYWNrU2VydmljZUNvZGVjLmphdmE=)
| `77.2% <0%> (-1.48%)` | `29% <0%> (ø)` | |
   | [...apache/dubbo/rpc/protocol/dubbo/DubboProtocol.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2529/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL0R1YmJvUHJvdG9jb2wuamF2YQ==)
| `58.33% <0%> (-0.84%)` | `30% <0%> (-1%)` | |
   | [...pache/dubbo/registry/support/AbstractRegistry.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2529/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9zdXBwb3J0L0Fic3RyYWN0UmVnaXN0cnkuamF2YQ==)
| `67.91% <0%> (-0.26%)` | `64% <0%> (ø)` | |
   | [.../rpc/cluster/router/condition/ConditionRouter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2529/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL2NvbmRpdGlvbi9Db25kaXRpb25Sb3V0ZXIuamF2YQ==)
| `71.64% <0%> (ø)` | `33% <0%> (ø)` | :arrow_down: |
   | ... and [18 more](https://codecov.io/gh/apache/incubator-dubbo/pull/2529/diff?src=pr&el=tree-more)
| |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2529?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2529?src=pr&el=footer).
Last update [cd60e58...6caa607](https://codecov.io/gh/apache/incubator-dubbo/pull/2529?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Mime
View raw message