dubbo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] zonghaishang commented on a change in pull request #2517: issue#2516: Remove getSpringContext() from org.apache.dubbo.config.spring.ServiceBean
Date Fri, 21 Sep 2018 10:05:49 GMT
zonghaishang commented on a change in pull request #2517:  issue#2516: Remove getSpringContext()
from org.apache.dubbo.config.spring.ServiceBean
URL: https://github.com/apache/incubator-dubbo/pull/2517#discussion_r219447452
 
 

 ##########
 File path: dubbo-config/dubbo-config-spring/src/main/java/org/apache/dubbo/config/spring/status/SpringStatusChecker.java
 ##########
 @@ -37,10 +37,18 @@
 
     @Override
     public Status check() {
-        ApplicationContext context = ServiceBean.getSpringContext();
+        ApplicationContext context = null;
+        for (ApplicationContext c : SpringExtensionFactory.getContexts()) {
 
 Review comment:
   The code is repeated multiple times, perhaps better after being refactored ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Mime
View raw message