dubbo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From 356082462 (GitHub) <git...@apache.org>
Subject [GitHub] [incubator-dubbo] 356082462 opened pull request #2565: [Dubbo-2545] 修复注册中心域名解析导致的单点问题
Date Wed, 26 Sep 2018 14:36:05 GMT
## What is the purpose of the change

修复注册中心域名解析导致的单点问题,参考:#2545
修复由于域名解析成同一个注册中心的不通IP导致创建多个Registry对象的问题。

## Brief changelog

将如下代码:
https://github.com/apache/incubator-dubbo/blob/e6b0bc8a856abd7f2d7a2e0f06ccc78dc90e2e0a/dubbo-registry/dubbo-registry-api/src/main/java/org/apache/dubbo/registry/support/AbstractRegistryFactory.java#L88
改为:
https://github.com/apache/incubator-dubbo/blob/7a48fac84b14ac6a21c1bdfc5958705dd8dda84d/dubbo-compatible/src/main/java/com/alibaba/dubbo/common/URL.java#L498-L500

## Verifying this change

org.apache.dubbo.registry.supportAbstractRegistryFactory

Follow this checklist to help us incorporate your contribution quickly and easily:

- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues)
filed for the change (usually before you start working on it). Trivial changes like typos
do not require a GITHUB issue. Your pull request should address just this issue, without pulling
in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config
not exist #XXX`. Each commit in the pull request should have a meaningful subject line and
body.
- [x] Write a pull request description that is detailed enough to understand what the pull
request does, how, and why.
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better
when cross module dependency exist. If the new feature or significant change is committed,
please remember to add integration-test in [test module](https://github.com/apache/incubator-dubbo/tree/master/dubbo-test).
- [x] Run `mvn clean install -DskipTests` & `mvn clean test-compile failsafe:integration-test`
to make sure unit-test and integration-test pass.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2565 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
Mime
View raw message