dubbo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From oldratlee (GitHub) <git...@apache.org>
Subject [GitHub] [incubator-dubbo] oldratlee commented on issue #2884: We need more code comments
Date Fri, 07 Dec 2018 13:12:33 GMT
> @ralf0131
>   @oldratlee Can you break it down by modules? We can start from the lowest.

comment coverage data per module sorted by product code: 

module  | product code | test code
------- | ---------  | ----------
dubbo-registry |  18.2%   | 19.2%  
dubbo-monitor | 25.3%        | 17.1% 
dubbo-config | 25.8% | 24.5%
dubbo-common  | 25.9% |  23.2%
dubbo-rpc |  27.4%  | 18.3%     
dubbo-remoting |   29.8%   | 22.4% 
dubbo-container | 31.5% | 55.3% 
dubbo-plugin |   34.3%  | 32.6% 
dubbo-filter | 34.7% | 32.5%
dubbo-serialization |   35.2% | 16.8%  
dubbo-cluster | 35.5% | 19.4%
dubbo-compatible | 40.3% | 23.8%
dubbo-metrics | 50.8% | 19.9% 
dubbo-test  |   51.5%  | -
dubbo-demo | 62.7% | -

PS:  
If needed, I can write a script to generate above table.

----------------------

Below is the quick-hack script to show coverage data per module:

```bash
$ for d in `find -mindepth 1 -maxdepth 1 -type d -name 'dubbo*'`; do  (
  echo
  echo "===================================="
  echo $d
  echo "===================================="
  cd $d
  ohcount **/src/main/; ohcount **/src/test/
)
done

......
====================================
./dubbo-cluster
====================================
Examining 67 file(s)

                          Ohloh Line Count Summary

Language          Files       Code    Comment  Comment %      Blank      Total
----------------  -----  ---------  ---------  ---------  ---------  ---------
java                 62       2544       1400      35.5%        490       4434
----------------  -----  ---------  ---------  ---------  ---------  ---------
Total                62       2544       1400      35.5%        490       4434
Examining 38 file(s)

                          Ohloh Line Count Summary

Language          Files       Code    Comment  Comment %      Blank      Total
----------------  -----  ---------  ---------  ---------  ---------  ---------
java                 34       3421        822      19.4%        706       4949
xml                   1         13         14      51.9%          2         29
----------------  -----  ---------  ---------  ---------  ---------  ---------
Total                35       3434        836      19.6%        708       4978

====================================
./dubbo-common
====================================
Examining 121 file(s)

                          Ohloh Line Count Summary

Language          Files       Code    Comment  Comment %      Blank      Total
----------------  -----  ---------  ---------  ---------  ---------  ---------
java                115      15045       5248      25.9%       2610      22903
----------------  -----  ---------  ---------  ---------  ---------  ---------
Total               115      15045       5248      25.9%       2610      22903
Examining 183 file(s)

                          Ohloh Line Count Summary

Language          Files       Code    Comment  Comment %      Blank      Total
----------------  -----  ---------  ---------  ---------  ---------  ---------
java                158       8846       2671      23.2%       1899      13416
xml                   1         14         18      56.2%          0         32
----------------  -----  ---------  ---------  ---------  ---------  ---------
Total               159       8860       2689      23.3%       1899      13448

......
```

[ Full content available at: https://github.com/apache/incubator-dubbo/issues/2884 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
Mime
View raw message