dubbo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From beiwei30 (GitHub) <git...@apache.org>
Subject [GitHub] [incubator-dubbo] beiwei30 commented on issue #2795: 如何关闭 dubbo telnet调试功能
Date Mon, 10 Dec 2018 08:36:13 GMT
I believe #2925 from @kexianjun should satisfy this particular requirement, to disable telnet,
simply configure 

<dubbo:protocol name="dubbo" port="20890" telnet="help"/>

In this way, only `help` is available for executing, and other commands are disabled.

I don't agree with the idea of introducing another flag to control this func. A better way
to disable telent should be:

<dubbo:protocol name="dubbo" port="20890" telnet="disabled"/>

Then we can use this magic word `disabled` in org.apache.dubbo.remoting.telnet.support.TelnetHandlerAdapter
to return immediately. 

What do you think, Guys?

[ Full content available at: https://github.com/apache/incubator-dubbo/issues/2795 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

View raw message