dubbo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From beiwei30 (GitHub) <git...@apache.org>
Subject [GitHub] [incubator-dubbo] beiwei30 commented on pull request #2803: Fix telnet can not find method with enum type
Date Mon, 10 Dec 2018 08:55:48 GMT
I think it is not necessary to call `CompatibleTypeUtils.compatibleTypeConvert(arg, type`,
this logic can be simplified as below, since we know arg is always a String type in this case.

```java
            if (ReflectUtils.isPrimitive(arg.getClass())) {
                if (!ReflectUtils.isPrimitive(type) && !type.isEnum()) {
                    return false;
                }
            }
```

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2803 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org


Mime
View raw message