dubbo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From CrazyHZM (GitHub) <git...@apache.org>
Subject [GitHub] [incubator-dubbo] CrazyHZM commented on pull request #3043: wrong event setting
Date Mon, 24 Dec 2018 01:45:02 GMT
If this is bad request,`req.setData(t);` will be executed,so I think `if (!req.isBroken())`
is necessary.
About `if ((flag & FLAG_EVENT) != 0)` , I think that plus him is just for insurance .
for example value of data  is "R" but it is not an event.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3043 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
View raw message