dubbo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From beiwei30 (GitHub) <git...@apache.org>
Subject [GitHub] [incubator-dubbo] beiwei30 opened pull request #2963: fix potential concurrency issue in a simpler way for ActiveLimitFilter and ExecuteLimitFilter
Date Fri, 14 Dec 2018 03:39:37 GMT
## What is the purpose of the change

Fix potential concurrency issue in a simpler way for ActiveLimitFilter and ExecuteLimitFilter.
The original changes are: d0e41e8733d0837653e5b2281f6d4b9f9508c2c1 and 2fad342ce1bd6afe683b001d063c82fb89237b48.
The semaphores introduced on RpcStatus are a little bit confusing.

## Brief changelog

dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/RpcStatus.java
dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/filter/ActiveLimitFilter.java
dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/filter/ExecuteLimitFilter.java

## Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues)
field for the change (usually before you start working on it). Trivial changes like typos
do not require a GITHUB issue. Your pull request should address just this issue, without pulling
in other changes - one PR resolves one issue.
- [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config
not exist #XXX`. Each commit in the pull request should have a meaningful subject line and
body.
- [ ] Write a pull request description that is detailed enough to understand what the pull
request does, how, and why.
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better
when cross module dependency exist. If the new feature or significant change is committed,
please remember to add integration-test in [test module](https://github.com/apache/incubator-dubbo/tree/master/dubbo-test).
- [ ] Run `mvn clean install -DskipTests` & `mvn clean test-compile failsafe:integration-test`
to make sure unit-test and integration-test pass.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2963 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org


Mime
View raw message