dubbo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From khanimteyaz (GitHub) <git...@apache.org>
Subject [GitHub] [incubator-dubbo] khanimteyaz opened pull request #2967: Documentation/2935#dubbo rpc api
Date Fri, 14 Dec 2018 20:19:01 GMT
## What is the purpose of the change

Added javadoc and documentation for dubbo-rpc-api filter package. 

## Brief changelog

Added documentation for java classes for developer, to provide high level idea what this current
class suppose to do.

## Verifying this change

Run build locally.

Follow this checklist to help us incorporate your contribution quickly and easily:

- [x] Make sure there is a [2935](https://github.com/apache/incubator-dubbo/issues/2935) field
for the change (usually before you start working on it). Trivial changes like typos do not
require a GITHUB issue. Your pull request should address just this issue, without pulling
in other changes - one PR resolves one issue.
- [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config
not exist #XXX`. Each commit in the pull request should have a meaningful subject line and
body.
- [ ] Write a pull request description that is detailed enough to understand what the pull
request does, how, and why.
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better
when cross module dependency exist. If the new feature or significant change is committed,
please remember to add integration-test in [test module](https://github.com/apache/incubator-dubbo/tree/master/dubbo-test).
- [ ] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile failsafe:integration-test`
to make sure unit-test and integration-test pass.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2967 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org


Mime
View raw message