dubbo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From beiwei30 (GitHub) <git...@apache.org>
Subject [GitHub] [incubator-dubbo] beiwei30 commented on issue #3785: dubbo-2.7.1 providers 重复注册
Date Wed, 03 Apr 2019 10:53:30 GMT
The original change made for fixing issue #195: @Reference check=false不生效 (#3530). For
some particular boolean flags, it should have the default value in order to align with the
default value from the annotation. 

In this case, the original value is null and the annotation default value is false. I double
checked how this value is used, and figured out its default value should be 'true', or roll
back to null.

@carryxyh would you mind to give it a try to change it to

protected Boolean dynamic = true;

pls. keep in mind you also need to change the default value from the annotation:

boolean dynamic() default true;

[ Full content available at: https://github.com/apache/incubator-dubbo/issues/3785 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
View raw message