dubbo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lzf971107 (GitHub) <git...@apache.org>
Subject [GitHub] [dubbo] lzf971107 opened pull request #5572: enhance the java doc of dubbo-common module.
Date Wed, 01 Jan 2020 06:46:30 GMT
## What is the purpose of the change


## Brief changelog


## Verifying this change

Passed unit test

Follow this checklist to help us incorporate your contribution quickly and easily:

- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/dubbo/issues) field for
the change (usually before you start working on it). Trivial changes like typos do not require
a GITHUB issue. Your pull request should address just this issue, without pulling in other
changes - one PR resolves one issue.
- [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config
not exist #XXX`. Each commit in the pull request should have a meaningful subject line and
- [ ] Write a pull request description that is detailed enough to understand what the pull
request does, how, and why.
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better
when cross module dependency exist. If the new feature or significant change is committed,
please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples)
- [ ] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile failsafe:integration-test`
to make sure unit-test and integration-test pass.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide).

[ Full content available at: https://github.com/apache/dubbo/pull/5572 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

View raw message