dubbo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [dubbo-go] fangyincheng commented on a change in pull request #1299: Rft: Filter
Date Tue, 06 Jul 2021 16:11:00 GMT

fangyincheng commented on a change in pull request #1299:
URL: https://github.com/apache/dubbo-go/pull/1299#discussion_r664684429



##########
File path: filter/tracing/filter.go
##########
@@ -96,7 +96,7 @@ func (tf *tracingFilter) OnResponse(ctx context.Context, result protocol.Result,
 
 var tracingFilterInstance *tracingFilter
 
-func newTracingFilter() filter.Filter {
+func NewTracingFilter() *tracingFilter {

Review comment:
       why open this method ?

##########
File path: filter/auth/provider_auth_filter.go
##########
@@ -58,7 +52,3 @@ func (paf *ProviderAuthFilter) Invoke(ctx context.Context, invoker protocol.Invo
 func (paf *ProviderAuthFilter) OnResponse(ctx context.Context, result protocol.Result, invoker
protocol.Invoker, invocation protocol.Invocation) protocol.Result {
 	return result
 }
-

Review comment:
       为什么删除?

##########
File path: filter/tps/strategy/sliding_window.go
##########
@@ -15,24 +15,24 @@
  * limitations under the License.
  */
 
-package tps
+package strategy
 
 import (
 	"container/list"
+	"dubbo.apache.org/dubbo-go/v3/filter"

Review comment:
       wrong import format

##########
File path: filter/execlmt/filter.go
##########
@@ -38,14 +38,16 @@ import (
 )
 
 const (
-	name = "execute"
+	ExecuteLimit = "execute"
 )
 
 func init() {
-	extension.SetFilter(name, GetExecuteLimitFilter)
+	extension.SetFilter(ExecuteLimit, func() filter.Filter {

Review comment:
       为什么要对NewFilter再封一个函数出来




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Mime
View raw message