dubbo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [dubbo] pinxiong commented on a change in pull request #8168: [3.0] Improve dubbo bootstrap initialization
Date Wed, 07 Jul 2021 00:25:59 GMT

pinxiong commented on a change in pull request #8168:
URL: https://github.com/apache/dubbo/pull/8168#discussion_r664953009



##########
File path: dubbo-config/dubbo-config-spring/src/main/java/org/apache/dubbo/config/spring/context/DubboConfigBeanInitializer.java
##########
@@ -32,56 +33,26 @@
 import org.springframework.beans.FatalBeanException;
 import org.springframework.beans.factory.BeanFactory;
 import org.springframework.beans.factory.BeanFactoryAware;
-import org.springframework.beans.factory.annotation.Value;
-import org.springframework.beans.factory.config.BeanPostProcessor;
+import org.springframework.beans.factory.InitializingBean;
 import org.springframework.beans.factory.config.ConfigurableListableBeanFactory;
-import org.springframework.context.ApplicationContext;
-import org.springframework.context.ApplicationContextAware;
-import org.springframework.core.Ordered;
 
 import java.util.concurrent.atomic.AtomicBoolean;
 
-import static org.springframework.beans.factory.BeanFactoryUtils.beansOfTypeIncludingAncestors;
 
 /**
  *
- * Post-processor Dubbo config bean initialization.
+ * Dubbo config bean initializer.
  *
  * NOTE: Dubbo config beans MUST be initialized after registering all BeanPostProcessors,
  * that is after the AbstractApplicationContext#registerBeanPostProcessors() method.
  */
-public class DubboConfigInitializationPostProcessor implements BeanPostProcessor, BeanFactoryAware,
ApplicationContextAware, Ordered {
+public class DubboConfigBeanInitializer implements BeanFactoryAware, InitializingBean {
 
-    public static String BEAN_NAME = "dubboConfigInitializationPostProcessor";
-
-    /**
-     * This bean post processor should run before seata GlobalTransactionScanner(1024)
-     */
-    @Value("${dubbo.config-initialization-post-processor.order:1000}")
-    private int order = 1000;
+    public static String BEAN_NAME = "dubboConfigInitializer";

Review comment:
       Should it be change to `dubboConfigBeanInitializer`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Mime
View raw message