dubbo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [dubbo] horizonzy commented on a change in pull request #8208: Throw the IllegalArgumentException if the address is empty to avoid NPE.
Date Sun, 11 Jul 2021 15:57:04 GMT

horizonzy commented on a change in pull request #8208:
URL: https://github.com/apache/dubbo/pull/8208#discussion_r667501477



##########
File path: dubbo-common/src/test/java/org/apache/dubbo/common/utils/UrlUtilsTest.java
##########
@@ -334,8 +344,8 @@ public void testIsItemMatch() throws Exception {
     public void testIsServiceKeyMatch() throws Exception {
         URL url = URL.valueOf("test://127.0.0.1");
         URL pattern = url.addParameter(GROUP_KEY, "test")
-                .addParameter(INTERFACE_KEY, "test")

Review comment:
       line indent should be fix.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Mime
View raw message